[
https://issues.apache.org/jira/browse/GOBBLIN-847?focusedWorklogId=294076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294076
]
ASF GitHub Bot logged work on GOBBLIN-847:
------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/19 18:08
Start Date: 13/Aug/19 18:08
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2702:
[GOBBLIN-847] Flow level sla
URL: https://github.com/apache/incubator-gobblin/pull/2702#discussion_r313538303
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -473,22 +490,20 @@ private void initialize(Dag<JobExecutionPlan> dag)
/**
* Proceed the execution of each dag node based on job status.
*/
- private void pollAndAdvanceDag()
- throws IOException {
+ private void pollAndAdvanceDag() throws IOException, ExecutionException,
InterruptedException {
this.failedDagIdsFinishRunning.clear();
-
Map<String, Set<DagNode<JobExecutionPlan>>> nextSubmitted =
Maps.newHashMap();
List<DagNode<JobExecutionPlan>> nodesToCleanUp = Lists.newArrayList();
+
for (DagNode<JobExecutionPlan> node: this.jobToDag.keySet()) {
- long pollStartTime = System.nanoTime();
+ boolean slaKilled = slaKillIfNeeded(node);
+
JobStatus jobStatus = pollJobStatus(node);
- Instrumented.updateTimer(this.jobStatusPolledTimer, System.nanoTime()
- pollStartTime, TimeUnit.NANOSECONDS);
- if (jobStatus == null) {
- continue;
- }
+
+ ExecutionStatus status = getJobExecutionStatus(slaKilled, jobStatus);
Review comment:
Almost the same thing, less readable and giving less emphasis on the fact
that slaKilled affects the execution status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 294076)
Time Spent: 3h 40m (was: 3.5h)
> add a flow level sla in gaas flows
> ----------------------------------
>
> Key: GOBBLIN-847
> URL: https://issues.apache.org/jira/browse/GOBBLIN-847
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> add a flow level sla in gaas flows, because sometimes azkaban jobs may not
> start and hence send any tracking event, or azkaban maybe down. in all those
> cases, we might have to kill the job so we can start a new job
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
