[
https://issues.apache.org/jira/browse/GOBBLIN-847?focusedWorklogId=294333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294333
]
ASF GitHub Bot logged work on GOBBLIN-847:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/19 01:56
Start Date: 14/Aug/19 01:56
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2702: [GOBBLIN-847]
Flow level sla
URL: https://github.com/apache/incubator-gobblin/pull/2702#discussion_r313678293
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -764,6 +777,12 @@ private void cleanUp() {
}
for (String dagId: dagIdstoClean) {
+ // send an event before cleaning up dag metadata
+ if (this.eventSubmitter.isPresent()) {
+ JobExecutionPlan jobExecutionPlan =
this.dags.get(dagId).getNodes().get(0).getValue();
+ Map<String, String> jobMetadata =
TimingEventUtils.getJobMetadata(Maps.newHashMap(), jobExecutionPlan);
+
this.eventSubmitter.get().getTimingEvent(TimingEvent.FlowTimings.FLOW_CANCEL).stop(jobMetadata);
Review comment:
Not every dag in dagIdsToClean is in CANCELLED state. Should lines 780-784
be moved to a separate method (e.g. emitFlowEvent()) in DagManagerUtils and be
invoked after line 772? And since we are treating cancelled flow as failed for
now, emit FLOW_FAILED event?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 294333)
Time Spent: 5h 10m (was: 5h)
> add a flow level sla in gaas flows
> ----------------------------------
>
> Key: GOBBLIN-847
> URL: https://issues.apache.org/jira/browse/GOBBLIN-847
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> add a flow level sla in gaas flows, because sometimes azkaban jobs may not
> start and hence send any tracking event, or azkaban maybe down. in all those
> cases, we might have to kill the job so we can start a new job
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
