ZihanLi58 commented on a change in pull request #2719: [GOBBLIN-863]Handle race
condition issue for hive registration
URL: https://github.com/apache/incubator-gobblin/pull/2719#discussion_r318255786
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -197,6 +211,18 @@ private boolean
ensureHiveTableExistenceBeforeAlternation(String tableName, Stri
try (Timer.Context context =
this.metricContext.timer(GET_HIVE_TABLE).time()) {
existingTable =
HiveMetaStoreUtils.getHiveTable(client.getTable(dbName, tableName));
}
+ //TODO: Determine whether we still use inline hive registration,
+ // if so, instead of fetching schema from schema registry, we need to
enable schema version
+ if (this.schemaRegistry.isPresent()) {
Review comment:
This is the previous thinking. But I realize this is not the final schema.
So I will implement schema version instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
