ZihanLi58 commented on a change in pull request #2719: [GOBBLIN-863]Handle race 
condition issue for hive registration
URL: https://github.com/apache/incubator-gobblin/pull/2719#discussion_r318285399
 
 

 ##########
 File path: 
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveRegister.java
 ##########
 @@ -94,29 +94,32 @@ protected HiveRegister(State state) {
 
       @Override
       public Void call() throws Exception {
+        try {
 
 Review comment:
   Because in streaming job, the TaskExecutor will not close, so it's hard to 
catch the exception when the executor finished. So I just want to print the 
error during the job, which I think will be more helpful for debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to