[ 
https://issues.apache.org/jira/browse/GOBBLIN-874?focusedWorklogId=309063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309063
 ]

ASF GitHub Bot logged work on GOBBLIN-874:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/19 16:47
            Start Date: 09/Sep/19 16:47
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2728: [GOBBLIN-874] 
Make WorkUnitPacker and SizeEstimator pluggable
URL: https://github.com/apache/incubator-gobblin/pull/2728#discussion_r322344949
 
 

 ##########
 File path: 
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaWorkUnitPacker.java
 ##########
 @@ -58,20 +59,34 @@
 
   private static final Logger LOG = 
LoggerFactory.getLogger(KafkaWorkUnitPacker.class);
 
+  /**
+   * For customized type of the following enums, it will try to find declared 
class in classpath
+   * and fallback to exception if ClassNotFound. This way the sizeEstimator 
and packer could be easier to
+   * extend. The major purpose for keeping this enum instead of using 
reflection only to construct the instance
 
 Review comment:
   +1. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 309063)
    Time Spent: 0.5h  (was: 20m)

> Make KafkaWUPacker and SizeEstimator pluggable 
> -----------------------------------------------
>
>                 Key: GOBBLIN-874
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-874
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to