[
https://issues.apache.org/jira/browse/GOBBLIN-874?focusedWorklogId=309137&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309137
]
ASF GitHub Bot logged work on GOBBLIN-874:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 18:18
Start Date: 09/Sep/19 18:18
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2728: [GOBBLIN-874] Make
WorkUnitPacker and SizeEstimator pluggable
URL:
https://github.com/apache/incubator-gobblin/pull/2728#issuecomment-529603187
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=h1)
Report
> Merging
[#2728](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/a409908079df873ba0d5a465df3e682be0e0085d?src=pr&el=desc)
will **increase** coverage by `0.06%`.
> The diff coverage is `90.9%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2728 +/- ##
============================================
+ Coverage 44.99% 45.05% +0.06%
- Complexity 8742 8753 +11
============================================
Files 1884 1884
Lines 70295 70302 +7
Branches 7715 7715
============================================
+ Hits 31629 31675 +46
+ Misses 35735 35688 -47
- Partials 2931 2939 +8
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...orkunit/packer/KafkaSingleLevelWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FTaW5nbGVMZXZlbFdvcmtVbml0UGFja2VyLmphdmE=)
| `12.5% <ø> (+12.5%)` | `1 <0> (+1)` | :arrow_up: |
|
[...ka/workunit/packer/KafkaBiLevelWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FCaUxldmVsV29ya1VuaXRQYWNrZXIuamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../KafkaAvgRecordSizeBasedWorkUnitSizeEstimator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FBdmdSZWNvcmRTaXplQmFzZWRXb3JrVW5pdFNpemVFc3RpbWF0b3IuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...act/kafka/workunit/packer/KafkaWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FXb3JrVW5pdFBhY2tlci5qYXZh)
| `16.48% <100%> (+16.48%)` | `6 <0> (+6)` | :arrow_up: |
|
[.../KafkaAvgRecordTimeBasedWorkUnitSizeEstimator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FBdmdSZWNvcmRUaW1lQmFzZWRXb3JrVW5pdFNpemVFc3RpbWF0b3IuamF2YQ==)
| `26.08% <100%> (+26.08%)` | `3 <0> (+3)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `66.19% <0%> (+0.93%)` | `29% <0%> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...ache/gobblin/couchbase/writer/CouchbaseWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyLmphdmE=)
| `68.6% <0%> (+2.32%)` | `11% <0%> (ø)` | :arrow_down: |
| ... and [2
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2728/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=footer).
Last update
[a409908...313e576](https://codecov.io/gh/apache/incubator-gobblin/pull/2728?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309137)
Time Spent: 50m (was: 40m)
> Make KafkaWUPacker and SizeEstimator pluggable
> -----------------------------------------------
>
> Key: GOBBLIN-874
> URL: https://issues.apache.org/jira/browse/GOBBLIN-874
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
