[
https://issues.apache.org/jira/browse/GOBBLIN-701?focusedWorklogId=309270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309270
]
ASF GitHub Bot logged work on GOBBLIN-701:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 21:35
Start Date: 09/Sep/19 21:35
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2571: [GOBBLIN-701]
Added the concept of secure job templates and job resolution callbacks.
URL: https://github.com/apache/incubator-gobblin/pull/2571#discussion_r322449453
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/StaticJobTemplate.java
##########
@@ -105,6 +114,17 @@ protected Config getLocalRawTemplate() {
@Override
protected Config getLocallyResolvedConfig(Config userConfig) {
- return userConfig.withFallback(this.rawConfig);
+ Config filteredUserConfig = SecureJobTemplate.filterUserConfig(this,
userConfig, log);
+ return filteredUserConfig.withFallback(this.rawConfig);
+ }
+
+ @Override
+ public boolean isSecure() {
+ return this.rawConfig.hasPath(IS_SECURE_KEY) &&
this.rawConfig.getBoolean(IS_SECURE_KEY);
Review comment:
ConfigUtils.getBoolean(rawConfig, IS_SECURE_KEY, false)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 309270)
Time Spent: 40m (was: 0.5h)
> Support for secure templates that limit which keys can be overriden
> -------------------------------------------------------------------
>
> Key: GOBBLIN-701
> URL: https://issues.apache.org/jira/browse/GOBBLIN-701
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Issac Buenrostro
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
