[ 
https://issues.apache.org/jira/browse/GOBBLIN-701?focusedWorklogId=309271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309271
 ]

ASF GitHub Bot logged work on GOBBLIN-701:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/19 21:35
            Start Date: 09/Sep/19 21:35
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2571: [GOBBLIN-701] 
Added the concept of secure job templates and job resolution callbacks.
URL: https://github.com/apache/incubator-gobblin/pull/2571#discussion_r322447907
 
 

 ##########
 File path: 
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
 ##########
 @@ -199,10 +202,13 @@ public AzkabanJobLauncher(String jobId, Properties props)
 
     Properties jobProps = this.props;
     if (jobProps.containsKey(TEMPLATE_KEY)) {
+      Config config = ConfigUtils.propertiesToConfig(jobProps);
+      JobSpecResolver resolver = JobSpecResolver.builder(config).build();
 
 Review comment:
   Shouldn't we pass a catalog (i.e. the PackagedTemplatesJobCatalogDecorator) 
to the JobSpecResolver Builder? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 309271)
    Time Spent: 50m  (was: 40m)

> Support for secure templates that limit which keys can be overriden
> -------------------------------------------------------------------
>
>                 Key: GOBBLIN-701
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-701
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Issac Buenrostro
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to