shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322481788
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
##########
@@ -133,4 +131,8 @@ public static void addFileAsLocalResource(FileSystem fs,
Path destFilePath, Loca
return environmentVariableMap;
}
+
+ public static String getContainerNum(String containerId) {
+ return "container-" + containerId.substring(containerId.lastIndexOf("_") +
1);
Review comment:
why are we doing + 1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
