[
https://issues.apache.org/jira/browse/GOBBLIN-875?focusedWorklogId=309389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309389
]
ASF GitHub Bot logged work on GOBBLIN-875:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 00:06
Start Date: 10/Sep/19 00:06
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2729: GOBBLIN-875:
Emit container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322504103
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
##########
@@ -133,4 +131,8 @@ public static void addFileAsLocalResource(FileSystem fs,
Path destFilePath, Loca
return environmentVariableMap;
}
+
+ public static String getContainerNum(String containerId) {
+ return "container-" + containerId.substring(containerId.lastIndexOf("_") +
1);
Review comment:
We want the substring starting from the char immediately following the last
"_". e.g. if containerId = "container_e94_1567552810874_2132400_01_000001", we
want to return
"container-000001". Added javadoc to make the behavior clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309389)
Time Spent: 1h (was: 50m)
> Emit container health metrics when running in cluster mode
> ----------------------------------------------------------
>
> Key: GOBBLIN-875
> URL: https://issues.apache.org/jira/browse/GOBBLIN-875
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This task implements a service that emits CPU/Memory health metrics from the
> JVM when running in the cluster mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
