ASF GitHub Bot logged work on GOBBLIN-875:

                Author: ASF GitHub Bot
            Created on: 10/Sep/19 04:31
            Start Date: 10/Sep/19 04:31
    Worklog Time Spent: 10m 
      Work Description: autumnust commented on pull request #2729: GOBBLIN-875: 
Emit container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322548013

 File path: 
 @@ -196,6 +196,11 @@ public GobblinTaskRunner(String applicationName,
+    if (ConfigUtils.getBoolean(this.config, 
false)) {
 Review comment:
   Sorry I should not mentioned `TaskRunnerSuiteBase`. What I meant to say is, 
does it make more sense to add this service inside `getServices` method in 
`GobblinTaskRunner` ?  
   The comment of `getServices` is :
   ```Creates and returns a {@link List} of additional {@link Service}s that 
should be run in this {@link GobblinTaskRunner}. Sub-classes that need 
additional {@link Service}s to run, should override this method```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 309523)
    Time Spent: 2h 10m  (was: 2h)

> Emit container health metrics when running in cluster mode
> ----------------------------------------------------------
>                 Key: GOBBLIN-875
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-875
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-cluster
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Hung Tran
>            Priority: Major
>             Fix For: 0.15.0
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
> This task implements a service that emits CPU/Memory health metrics from the 
> JVM when running in the cluster mode. 

This message was sent by Atlassian Jira

Reply via email to