shirshanka commented on a change in pull request #2730: GOBBLIN-876: Expose
metrics() API in GobblinKafkaConsumerClient to al…
URL: https://github.com/apache/incubator-gobblin/pull/2730#discussion_r325302830
##########
File path:
gobblin-modules/gobblin-kafka-09/src/main/java/org/apache/gobblin/kafka/client/Kafka09ConsumerClient.java
##########
@@ -162,6 +170,35 @@ public KafkaConsumerRecord apply(ConsumerRecord<K, V>
input) {
});
}
+ @Override
+ public Map<String, Metric> metrics() {
+ Map<MetricName, KafkaMetric> kafkaMetrics = (Map<MetricName, KafkaMetric>)
this.consumer.metrics();
+ Map<String, Metric> codaHaleMetricMap = new HashMap<>();
Review comment:
do we need a new instance every time?
This diff doesn't show when and how this method is being called, so its hard
to say if this new instance and copy on each call to metrics is a good idea or
not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
