[
https://issues.apache.org/jira/browse/GOBBLIN-865?focusedWorklogId=316377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316377
]
ASF GitHub Bot logged work on GOBBLIN-865:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 02:31
Start Date: 23/Sep/19 02:31
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2722: GOBBLIN-865:
Add feature that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r326307389
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
##########
@@ -869,7 +862,7 @@ public SalesforceBulkJobId
getQueryResultIdsPkChunking(String entity, List<Predi
// wait for completion, failure, or formation of PK chunking batches
while ((bulkBatchInfo.getState() != BatchStateEnum.Completed)
&& (bulkBatchInfo.getState() != BatchStateEnum.Failed)
- && (!usingPkChunking || bulkBatchInfo.getState() !=
BatchStateEnum.NotProcessed)) {
+ && (bulkBatchInfo.getState() != BatchStateEnum.NotProcessed)) {
Review comment:
Is skipping over this state safe for the non-pk chunking case? Could it be a
valid waiting state for non-pk chunking queries?
I think we should raise an error if there are any NotProcessed batches and
if there are more than one NotProcessed batches for PK chunking mode since that
indicates some expected work was not performed and there may be data loss if we
move the checkpoint forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 316377)
> Add feature that enables PK-chunking in partition
> --------------------------------------------------
>
> Key: GOBBLIN-865
> URL: https://issues.apache.org/jira/browse/GOBBLIN-865
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Alex Li
> Priority: Major
> Labels: salesforce
> Time Spent: 7h
> Remaining Estimate: 0h
>
> In SFDC(salesforce) connector, we have partitioning mechanisms to split a
> giant query to multiple sub queries. There are 3 mechanisms:
> * simple partition (equally split by time)
> * dynamic pre-partition (generate histogram and split by row numbers)
> * user specified partition (set up time range in job file)
> However there are tables like Task and Contract are failing time to time to
> fetch full data.
> We may want to utilize PK-chunking to partition the query.
>
> The pk-chunking doc from SFDC -
> [https://developer.salesforce.com/docs/atlas.en-us.api_asynch.meta/api_asynch/async_api_headers_enable_pk_chunking.htm]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
