[
https://issues.apache.org/jira/browse/GOBBLIN-865?focusedWorklogId=316863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316863
]
ASF GitHub Bot logged work on GOBBLIN-865:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 17:40
Start Date: 23/Sep/19 17:40
Worklog Time Spent: 10m
Work Description: arekusuri commented on pull request #2722: GOBBLIN-865:
Add feature that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r327243183
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
##########
@@ -857,7 +850,7 @@ public SalesforceBulkJobId
getQueryResultIdsPkChunking(String entity, List<Predi
BatchInfo bulkBatchInfo =
this.bulkConnection.createBatchFromStream(this.bulkJob, bout);
- long expectedSizePerBatch = usingPkChunking ? this.pkChunkingSize :
this.getExpectedRecordCount();
+ long expectedSizePerBatch = this.getExpectedRecordCount();
Review comment:
My original approach was - change this function as less as possible. But you
asked to remove a lot useless code, my understanding was to clean up the
pk-chunking logic from this function.
I removed the field `this.usingPkChunking` so we have to remove this part.
It won't break anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 316863)
Time Spent: 7h 50m (was: 7h 40m)
> Add feature that enables PK-chunking in partition
> --------------------------------------------------
>
> Key: GOBBLIN-865
> URL: https://issues.apache.org/jira/browse/GOBBLIN-865
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Alex Li
> Priority: Major
> Labels: salesforce
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> In SFDC(salesforce) connector, we have partitioning mechanisms to split a
> giant query to multiple sub queries. There are 3 mechanisms:
> * simple partition (equally split by time)
> * dynamic pre-partition (generate histogram and split by row numbers)
> * user specified partition (set up time range in job file)
> However there are tables like Task and Contract are failing time to time to
> fetch full data.
> We may want to utilize PK-chunking to partition the query.
>
> The pk-chunking doc from SFDC -
> [https://developer.salesforce.com/docs/atlas.en-us.api_asynch.meta/api_asynch/async_api_headers_enable_pk_chunking.htm]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
