sv2000 commented on a change in pull request #2769: [GOBBLIN-917] kill orphan
gaas jobs
URL: https://github.com/apache/incubator-gobblin/pull/2769#discussion_r336314957
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -545,8 +542,26 @@ private void pollAndAdvanceDag() throws IOException,
ExecutionException, Interru
}
}
- private ExecutionStatus getJobExecutionStatus(boolean slaKilled, JobStatus
jobStatus) {
- if (slaKilled) {
+ // cancel the job and returns true if the job status remains ORCHESTRATED
for some specific time
Review comment:
Use javadoc syntax:
/**
* Cancel the job if the job has been "orphaned". A job is orphaned if
{provide definition of orhphaned job}.
@return true if ....
**/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
