sv2000 commented on a change in pull request #2769: [GOBBLIN-917] kill orphan
gaas jobs
URL: https://github.com/apache/incubator-gobblin/pull/2769#discussion_r336314407
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -491,12 +486,14 @@ private void pollAndAdvanceDag() throws IOException,
ExecutionException, Interru
Map<String, Set<DagNode<JobExecutionPlan>>> nextSubmitted =
Maps.newHashMap();
List<DagNode<JobExecutionPlan>> nodesToCleanUp = Lists.newArrayList();
- for (DagNode<JobExecutionPlan> node: this.jobToDag.keySet()) {
+ for (DagNode<JobExecutionPlan> node : this.jobToDag.keySet()) {
boolean slaKilled = slaKillIfNeeded(node);
JobStatus jobStatus = pollJobStatus(node);
- ExecutionStatus status = getJobExecutionStatus(slaKilled, jobStatus);
+ boolean killOrphanFlow = killOrphanFlows(node, jobStatus);
Review comment:
killOrphanFlows -> killJobIfOrphaned(node, jobStatus);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
