[
https://issues.apache.org/jira/browse/GOBBLIN-946?focusedWorklogId=338963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338963
]
ASF GitHub Bot logged work on GOBBLIN-946:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 19:45
Start Date: 05/Nov/19 19:45
Worklog Time Spent: 10m
Work Description: haojiliu commented on pull request #2796: [GOBBLIN-946]
Add HttpDatasetDescriptor and HttpDataNode to Gobblin Service
URL: https://github.com/apache/incubator-gobblin/pull/2796
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-946
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Adding support for transmitting data from a http/https source. This is the
first effort and minimum number of attributes were introduced.
A HttpDataNode will specify two attributes:
1. domain - This is the domain component of a http url
2. authentication type - This is the authentication protocol supported for a
given domain
A HttpDatasetDescriptor will specify one attribute:
1. path - This is the full url of the data source's endpoint, e.g,
https://a.b.c.com/api/dataset_abc
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Custom logics are covered by unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 338963)
Remaining Estimate: 35h 50m (was: 36h)
Time Spent: 10m
> Support HTTP source in Gobblin Service
> --------------------------------------
>
> Key: GOBBLIN-946
> URL: https://issues.apache.org/jira/browse/GOBBLIN-946
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Haoji Liu
> Assignee: Abhishek Tiwari
> Priority: Major
> Original Estimate: 36h
> Time Spent: 10m
> Remaining Estimate: 35h 50m
>
> Adding support for transmitting data from a http/https source. This will
> require a new DataNode and DatasetDescriptor class.
>
> Minimal logic should be implemented, logics should reside in the actual
> gobblin connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
