[
https://issues.apache.org/jira/browse/GOBBLIN-946?focusedWorklogId=338995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338995
]
ASF GitHub Bot logged work on GOBBLIN-946:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 20:57
Start Date: 05/Nov/19 20:57
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2796: [GOBBLIN-946] Add
HttpDatasetDescriptor and HttpDataNode to Gobblin Service
URL:
https://github.com/apache/incubator-gobblin/pull/2796#issuecomment-550016552
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=h1)
Report
> Merging
[#2796](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/94a508b38ec8bd879614f2d9bf0eeb96513ca7cf?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `61.76%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2796 +/- ##
============================================
+ Coverage 45.32% 45.34% +0.01%
- Complexity 8862 8869 +7
============================================
Files 1894 1896 +2
Lines 70910 70943 +33
Branches 7799 7802 +3
============================================
+ Hits 32141 32169 +28
- Misses 35803 35806 +3
- Partials 2966 2968 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../modules/flowgraph/FlowGraphConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvRmxvd0dyYXBoQ29uZmlndXJhdGlvbktleXMuamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../service/modules/dataset/SqlDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L1NxbERhdGFzZXREZXNjcmlwdG9yLmphdmE=)
| `63.88% <100%> (ø)` | `7 <0> (ø)` | :arrow_down: |
|
[...vice/modules/flowgraph/datanodes/HttpDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL0h0dHBEYXRhTm9kZS5qYXZh)
| `41.66% <41.66%> (ø)` | `1 <1> (?)` | |
|
[...service/modules/dataset/HttpDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0h0dHBEYXRhc2V0RGVzY3JpcHRvci5qYXZh)
| `71.42% <71.42%> (ø)` | `5 <5> (?)` | |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
| ... and [3
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2796/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=footer).
Last update
[94a508b...dbbc0e7](https://codecov.io/gh/apache/incubator-gobblin/pull/2796?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 338995)
Remaining Estimate: 35h 40m (was: 35h 50m)
Time Spent: 20m (was: 10m)
> Support HTTP source in Gobblin Service
> --------------------------------------
>
> Key: GOBBLIN-946
> URL: https://issues.apache.org/jira/browse/GOBBLIN-946
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Haoji Liu
> Assignee: Abhishek Tiwari
> Priority: Major
> Original Estimate: 36h
> Time Spent: 20m
> Remaining Estimate: 35h 40m
>
> Adding support for transmitting data from a http/https source. This will
> require a new DataNode and DatasetDescriptor class.
>
> Minimal logic should be implemented, logics should reside in the actual
> gobblin connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
