autumnust commented on a change in pull request #2795: GOBBLIN-945: Refactor
Kafka extractor statistics tracking to allow co…
URL: https://github.com/apache/incubator-gobblin/pull/2795#discussion_r342739486
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java
##########
@@ -392,112 +303,16 @@ public long getExpectedRecordCount() {
@Override
public void close() throws IOException {
- if (currentPartitionIdx != INITIAL_PARTITION_IDX) {
- updateStatisticsForCurrentPartition();
+ if (!allPartitionsFinished()) {
Review comment:
condition for `allPartitionsFinished()` is stronger than `currentIdx !=
INITIAL_PARTITION_IDX` where the former requires ending of current partition as
well. Is that expected ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
