autumnust commented on a change in pull request #2795: GOBBLIN-945: Refactor
Kafka extractor statistics tracking to allow co…
URL: https://github.com/apache/incubator-gobblin/pull/2795#discussion_r342765903
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/GobblinKafkaConsumerClient.java
##########
@@ -72,6 +73,15 @@
*/
public long getLatestOffset(KafkaPartition partition) throws
KafkaOffsetRetrievalFailureException;
+ /**
+ * Get the latest available offset for a <code>partition</code>
+ *
+ * @param partitions for which latest offset is retrieved
+ *
+ * @throws UnsupportedOperationException - If the underlying kafka-client
does not support getting latest offset
+ */
+ public Map<KafkaPartition, Long> getLatestOffsets(Collection<KafkaPartition>
partitions) throws KafkaOffsetRetrievalFailureException;
Review comment:
Make a default impl. in interface instead ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
