[
https://issues.apache.org/jira/browse/GOBBLIN-933?focusedWorklogId=340296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340296
]
ASF GitHub Bot logged work on GOBBLIN-933:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 02:03
Start Date: 08/Nov/19 02:03
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2800: [GOBBLIN-933] add
support for array of unions in json schema_new
URL:
https://github.com/apache/incubator-gobblin/pull/2800#issuecomment-551350887
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=h1)
Report
> Merging
[#2800](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/e785b02d9fd59dbeb4282387d1956778df4f6fca?src=pr&el=desc)
will **increase** coverage by `0.96%`.
> The diff coverage is `74.19%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2800 +/- ##
============================================
+ Coverage 44.5% 45.46% +0.96%
- Complexity 8726 8898 +172
============================================
Files 1897 1897
Lines 70975 71006 +31
Branches 7804 7812 +8
============================================
+ Hits 31587 32286 +699
+ Misses 36460 35747 -713
- Partials 2928 2973 +45
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ro/JsonElementConversionWithAvroSchemaFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbldpdGhBdnJvU2NoZW1hRmFjdG9yeS5qYXZh)
| `74.72% <74.19%> (-0.28%)` | `6 <0> (+1)` | |
|
[...in/java/org/apache/gobblin/cluster/SingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFzay5qYXZh)
| `73.58% <0%> (-7.55%)` | `9% <0%> (ø)` | |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `76.08% <0%> (-4.35%)` | `5% <0%> (ø)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.71% <0%> (-2.81%)` | `11% <0%> (-1%)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.42% <0%> (-1.86%)` | `27% <0%> (-1%)` | |
|
[...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh)
| `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
|
[.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==)
| `47.31% <0%> (+0.48%)` | `29% <0%> (ø)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.87% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: |
|
[...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh)
| `59.13% <0%> (+0.8%)` | `33% <0%> (+2%)` | :arrow_up: |
| ... and [43
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2800/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=footer).
Last update
[e785b02...7bb949c](https://codecov.io/gh/apache/incubator-gobblin/pull/2800?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340296)
Time Spent: 3h 50m (was: 3h 40m)
> JsonRecordAvroSchemaToAvroConverter does not handle arrays of unions
> --------------------------------------------------------------------
>
> Key: GOBBLIN-933
> URL: https://issues.apache.org/jira/browse/GOBBLIN-933
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Ahmed Abdul Hamid
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Using {{JsonRecordAvroSchemaToAvroConverter}} to convert an array of a union
> type fails. For instance, using it with the following Avro schema:
> {code:java}
> {
> "name": "arrayField",
> "type": {
> "type": "array",
> "items": ["string", "null"]
> }
> } {code}
> yields the following error:
> {code:java}
> java.lang.StackOverflowError
> at org.apache.gobblin.configuration.State.getProp(State.java)
> at
> org.apache.gobblin.configuration.WorkUnitState.getProp(WorkUnitState.java:333)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory.getConvertor(JsonElementConversionFactory.java:106)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.getConverter(JsonElementConversionFactory.java:737)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.<init>(JsonElementConversionFactory.java:729)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory.getConvertor(JsonElementConversionFactory.java:160)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.getConverter(JsonElementConversionFactory.java:737)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.<init>(JsonElementConversionFactory.java:729)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
