[
https://issues.apache.org/jira/browse/GOBBLIN-933?focusedWorklogId=340647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340647
]
ASF GitHub Bot logged work on GOBBLIN-933:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 18:13
Start Date: 08/Nov/19 18:13
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2800:
[GOBBLIN-933] add support for array of unions in json schema_new
URL: https://github.com/apache/incubator-gobblin/pull/2800#discussion_r344301899
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/converter/avro/JsonElementConversionWithAvroSchemaFactory.java
##########
@@ -210,4 +216,70 @@ public Schema schema() {
return this.schema;
}
}
-}
+
+ public static class UnionConverter extends ComplexConverter {
+ private final List<Schema> schemas;
+ private final List<JsonElementConverter> converters;
+ private final Schema schemaNode;
+
+ public UnionConverter(String fieldName, boolean nullable, String
sourceType, Schema schemaNode,
+ WorkUnitState state, List<String> ignoreFields) throws
UnsupportedDateTypeException {
+ super(fieldName, nullable, sourceType);
+ this.schemas = schemaNode.getTypes();
+ converters = new ArrayList<>();
+ for(Schema schema: schemas) {
+ converters.add(getConvertor(fieldName, schema.getType().getName(),
schemaNode, state, isNullable(), ignoreFields));
+ }
+ this.schemaNode = schemaNode;
+ }
+
+ @Override
+ Object convertField(JsonElement value) {
+ for(JsonElementConverter converter: converters)
+ {
+ try {
+ Object o = converter.convert(value);
+ return o;
+ } catch (Exception e){}
+ }
+ throw new RuntimeException(StringFormatter.format("Cannot convert %s to
avro using schema %s", value.getAsString(), schemaNode.toString()).toString());
+ }
+
+ @Override
+ public Schema.Type getTargetType() {
+ if(schemas.size() == 2 && isNullable())
+ {
+ if(schemas.get(0).getType() == Schema.Type.NULL) {
+ return schemas.get(1).getType();
+ } else {
+ return schemas.get(0).getType();
+ }
+ }
+ return Schema.Type.UNION;
+ }
+
+ @Override
+ public Schema schema() {
+ if(schemas.size() == 2 && isNullable())
Review comment:
Sorry, I did not understand why this check is required.
Also, start braces should be in this line, not in the next line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340647)
Time Spent: 4h 10m (was: 4h)
> JsonRecordAvroSchemaToAvroConverter does not handle arrays of unions
> --------------------------------------------------------------------
>
> Key: GOBBLIN-933
> URL: https://issues.apache.org/jira/browse/GOBBLIN-933
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Ahmed Abdul Hamid
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Using {{JsonRecordAvroSchemaToAvroConverter}} to convert an array of a union
> type fails. For instance, using it with the following Avro schema:
> {code:java}
> {
> "name": "arrayField",
> "type": {
> "type": "array",
> "items": ["string", "null"]
> }
> } {code}
> yields the following error:
> {code:java}
> java.lang.StackOverflowError
> at org.apache.gobblin.configuration.State.getProp(State.java)
> at
> org.apache.gobblin.configuration.WorkUnitState.getProp(WorkUnitState.java:333)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory.getConvertor(JsonElementConversionFactory.java:106)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.getConverter(JsonElementConversionFactory.java:737)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.<init>(JsonElementConversionFactory.java:729)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory.getConvertor(JsonElementConversionFactory.java:160)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.getConverter(JsonElementConversionFactory.java:737)
> at
> org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.<init>(JsonElementConversionFactory.java:729)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
