autumnust commented on a change in pull request #2803: [GOBBLIN-954] Added
support to swap different HiveRegistrationPublishers
URL: https://github.com/apache/incubator-gobblin/pull/2803#discussion_r344424523
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/HiveRegTaskStateCollectorServiceHandlerImpl.java
##########
@@ -39,16 +41,25 @@
private HiveRegistrationPublisher hiveRegHandler;
public HiveRegTaskStateCollectorServiceHandlerImpl(JobState jobState) {
- hiveRegHandler = new HiveRegistrationPublisher(jobState);
+ String className = jobState
+ .getProp(ConfigurationKeys.HIVE_REG_PUBLISHER_CLASS,
ConfigurationKeys.DEFAULT_HIVE_REG_PUBLISHER_CLASS);
+ try {
+ hiveRegHandler =
+ (HiveRegistrationPublisher)
Class.forName(className).getConstructor(State.class).newInstance(jobState);
+ } catch (Exception e) {
Review comment:
What's the specific type of exception here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
