autumnust commented on a change in pull request #2803: [GOBBLIN-954] Added
support to swap different HiveRegistrationPublishers
URL: https://github.com/apache/incubator-gobblin/pull/2803#discussion_r344424365
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/publisher/BaseDataPublisher.java
##########
@@ -290,6 +290,7 @@ public void close()
for (Path path : this.publisherOutputDirs) {
this.state.appendToSetProp(ConfigurationKeys.PUBLISHER_DIRS,
path.toString());
}
+
this.state.setProp(ConfigurationKeys.PUBLISHER_LATEST_FILE_ARRIVAL_TIMESTAMP,
System.currentTimeMillis());
Review comment:
I would suggest make `System.currentTimeMillis()` into a protected method as
the default implementation(with a state object as parameter input) so that it
can be easily extended in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
