[
https://issues.apache.org/jira/browse/GOBBLIN-960?focusedWorklogId=343909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343909
]
ASF GitHub Bot logged work on GOBBLIN-960:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 00:41
Start Date: 15/Nov/19 00:41
Worklog Time Spent: 10m
Work Description: jack-moseley commented on pull request #2809:
[GOBBLIN-960]Resolving multiple templates in top-level
URL: https://github.com/apache/incubator-gobblin/pull/2809#discussion_r346616441
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/StaticJobTemplate.java
##########
@@ -64,13 +64,23 @@
private Collection<String> dependencies;
public StaticJobTemplate(URI uri, String version, String description, Config
config, JobCatalogWithTemplates catalog)
- throws SpecNotFoundException, TemplateException {
+ throws TemplateException {
this(uri, version, description, config, getSuperTemplateUris(config),
catalog);
}
+ /** An constructor that materialize multiple templates into a single static
template
+ * The constructor provided multiple existing templates as the input instead
of templateURIs
Review comment:
`multiple in-memory templates` instead of `multiple existing templates`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 343909)
Time Spent: 40m (was: 0.5h)
> Enable multiple top-level job templates resolution
> ---------------------------------------------------
>
> Key: GOBBLIN-960
> URL: https://issues.apache.org/jira/browse/GOBBLIN-960
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
