[
https://issues.apache.org/jira/browse/GOBBLIN-960?focusedWorklogId=344532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344532
]
ASF GitHub Bot logged work on GOBBLIN-960:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 19:45
Start Date: 15/Nov/19 19:45
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2809:
[GOBBLIN-960]Resolving multiple templates in top-level
URL: https://github.com/apache/incubator-gobblin/pull/2809#discussion_r346983423
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/InheritingJobTemplate.java
##########
@@ -103,13 +132,14 @@ public Config getRawTemplateConfig() throws
SpecNotFoundException, TemplateExcep
private Config getRawTemplateConfigHelper(Set<JobTemplate>
alreadyInheritedTemplates)
throws SpecNotFoundException, TemplateException {
Config rawTemplate = getLocalRawTemplate();
- for (JobTemplate template : Lists.reverse(this.superTemplates)) {
- if (!alreadyInheritedTemplates.contains(template)) {
- alreadyInheritedTemplates.add(template);
- Config thisFallback = template instanceof InheritingJobTemplate
- ? ((InheritingJobTemplate)
template).getRawTemplateConfigHelper(alreadyInheritedTemplates)
- : template.getRawTemplateConfig();
- rawTemplate = rawTemplate.withFallback(thisFallback);
+ if (this.superTemplates != null) {
Review comment:
It needs to be added because this change essentially gives resolution
process an interface to provide loaded templates and ask for resolution,
instead of providing template URI and ask for resolution as it was. This is
used for determining if the physical templates are provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344532)
Time Spent: 1h 10m (was: 1h)
> Enable multiple top-level job templates resolution
> ---------------------------------------------------
>
> Key: GOBBLIN-960
> URL: https://issues.apache.org/jira/browse/GOBBLIN-960
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
