[
https://issues.apache.org/jira/browse/GOBBLIN-970?focusedWorklogId=345655&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345655
]
ASF GitHub Bot logged work on GOBBLIN-970:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/19 23:13
Start Date: 18/Nov/19 23:13
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2815: GOBBLIN-970: Pass
metric context from the KafkaSource to the KafkaWor…
URL:
https://github.com/apache/incubator-gobblin/pull/2815#issuecomment-555253951
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=h1)
Report
> Merging
[#2815](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/e24bc26a28434bfee9ea4926e1b7d59901e63ec8?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2815 +/- ##
============================================
- Coverage 45.56% 45.56% -0.01%
+ Complexity 8954 8951 -3
============================================
Files 1900 1900
Lines 71213 71215 +2
Branches 7856 7856
============================================
Hits 32451 32451
+ Misses 35780 35775 -5
- Partials 2982 2989 +7
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...bblin/runtime/StateStoreBasedWatermarkStorage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU3RhdGVTdG9yZUJhc2VkV2F0ZXJtYXJrU3RvcmFnZS5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...in/source/extractor/extract/kafka/KafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...act/kafka/workunit/packer/KafkaWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FXb3JrVW5pdFBhY2tlci5qYXZh)
| `15.87% <40%> (-0.17%)` | `6 <0> (ø)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0%> (-7.15%)` | `4% <0%> (ø)` | |
|
[...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==)
| `73.48% <0%> (-3.04%)` | `18% <0%> (-3%)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.53% <0%> (+0.33%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2815/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=footer).
Last update
[e24bc26...3c518c3](https://codecov.io/gh/apache/incubator-gobblin/pull/2815?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345655)
Time Spent: 0.5h (was: 20m)
> Pass metric context from the KafkaSource to the KafkaWorkUnitPacker for
> emission of metrics from the packer
> -----------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-970
> URL: https://issues.apache.org/jira/browse/GOBBLIN-970
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Pass metric context from the KafkaSource to the KafkaWorkUnitPacker for
> emission of bin packing related metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
