[
https://issues.apache.org/jira/browse/GOBBLIN-970?focusedWorklogId=345682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345682
]
ASF GitHub Bot logged work on GOBBLIN-970:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 00:02
Start Date: 19/Nov/19 00:02
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2815: GOBBLIN-970:
Pass metric context from the KafkaSource to the KafkaWor…
URL: https://github.com/apache/incubator-gobblin/pull/2815#discussion_r347671916
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaWorkUnitPacker.java
##########
@@ -367,19 +368,19 @@ private static void
logMultiWorkUnitInfo(Iterable<MultiWorkUnit> mwus) {
return partitions;
}
- public static KafkaWorkUnitPacker getInstance(AbstractSource<?, ?> source,
SourceState state) {
Review comment:
Should we keep the original function to make the change backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345682)
Time Spent: 40m (was: 0.5h)
> Pass metric context from the KafkaSource to the KafkaWorkUnitPacker for
> emission of metrics from the packer
> -----------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-970
> URL: https://issues.apache.org/jira/browse/GOBBLIN-970
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Pass metric context from the KafkaSource to the KafkaWorkUnitPacker for
> emission of bin packing related metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
