[
https://issues.apache.org/jira/browse/GOBBLIN-964?focusedWorklogId=345717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345717
]
ASF GitHub Bot logged work on GOBBLIN-964:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 00:32
Start Date: 19/Nov/19 00:32
Worklog Time Spent: 10m
Work Description: enjoyear commented on pull request #2817: [GOBBLIN-964]
Add the enum JOB_SUCCEEDED to org.apache.gobblin.metrics.event.EventName
URL: https://github.com/apache/incubator-gobblin/pull/2817
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-964]] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-964
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
In the notifyListeners method of AbstractJobLauncher, it is unable to
convert the TimingEvent.LauncherTimings.JOB_SUCCEEDED successfully into a valid
EventName with this line below
EventName.getEnumFromEventId(timerEventName)
We miss an enum for JobSucceededTimer in
org.apache.gobblin.metrics.event.EventName
Without this enum, EventMetadataGenerator cannot work correctly to generate
additionalMetadata for the event
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345717)
Remaining Estimate: 0h
Time Spent: 10m
> JobSucceededTimer is missing in org.apache.gobblin.metrics.event.EventName
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-964
> URL: https://issues.apache.org/jira/browse/GOBBLIN-964
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Chen Guo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the notifyListeners method of AbstractJobLauncher, it is unable to convert
> the TimingEvent.LauncherTimings.JOB_SUCCEEDED successfully into a valid
> EventName with this line below
> {code:java}
> EventName.getEnumFromEventId(timerEventName)
> {code}
> We miss an enum for JobSucceededTimer in
> org.apache.gobblin.metrics.event.EventName
> Without this enum, EventMetadataGenerator cannot work correctly to generate
> additionalMetadata for the event
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
