[
https://issues.apache.org/jira/browse/GOBBLIN-964?focusedWorklogId=345766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345766
]
ASF GitHub Bot logged work on GOBBLIN-964:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 02:20
Start Date: 19/Nov/19 02:20
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2817: [GOBBLIN-964] Add
the enum JOB_SUCCEEDED to org.apache.gobblin.metrics.event.EventName
URL:
https://github.com/apache/incubator-gobblin/pull/2817#issuecomment-555301159
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=h1)
Report
> Merging
[#2817](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/e24bc26a28434bfee9ea4926e1b7d59901e63ec8?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2817 +/- ##
============================================
- Coverage 45.56% 45.56% -0.01%
+ Complexity 8954 8953 -1
============================================
Files 1900 1900
Lines 71213 71214 +1
Branches 7856 7856
============================================
- Hits 32451 32450 -1
+ Misses 35780 35778 -2
- Partials 2982 2986 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...va/org/apache/gobblin/metrics/event/EventName.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9FdmVudE5hbWUuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0%> (-7.15%)` | `4% <0%> (ø)` | |
|
[...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==)
| `73.48% <0%> (-3.04%)` | `18% <0%> (-3%)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `65.27% <0%> (+0.46%)` | `28% <0%> (ø)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.87% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2817/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=footer).
Last update
[e24bc26...6522f30](https://codecov.io/gh/apache/incubator-gobblin/pull/2817?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345766)
Time Spent: 20m (was: 10m)
> JobSucceededTimer is missing in org.apache.gobblin.metrics.event.EventName
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-964
> URL: https://issues.apache.org/jira/browse/GOBBLIN-964
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Chen Guo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In the notifyListeners method of AbstractJobLauncher, it is unable to convert
> the TimingEvent.LauncherTimings.JOB_SUCCEEDED successfully into a valid
> EventName with this line below
> {code:java}
> EventName.getEnumFromEventId(timerEventName)
> {code}
> We miss an enum for JobSucceededTimer in
> org.apache.gobblin.metrics.event.EventName
> Without this enum, EventMetadataGenerator cannot work correctly to generate
> additionalMetadata for the event
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
