[
https://issues.apache.org/jira/browse/GOBBLIN-963?focusedWorklogId=345721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345721
]
ASF GitHub Bot logged work on GOBBLIN-963:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 00:41
Start Date: 19/Nov/19 00:41
Worklog Time Spent: 10m
Work Description: enjoyear commented on pull request #2818: [GOBBLIN-963]
Remove duplicated copies of TaskContext/TaskState when constructing
TaskIFaceWrapper
URL: https://github.com/apache/incubator-gobblin/pull/2818
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-963] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-963
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
Currently in GobblinMultiTaskAttempt, when we call createTaskRunnable, we
rely on a TaskFactory to create a task and return a wrapper for that task.
However, when we create the wrapper, we initialized the TaskContext twice.
For the task creation
For the task wrapper creation
These two TaskContexts, which generate two copies of TaskState, will cause
inconsistency in the following operation. The task state update within the task
won't be reflected in TaskWrapper.
Specifically, this is the buggy line of code
```java
return new TaskIFaceWrapper(taskFactoryOpt.get().createTask(new
TaskContext(workUnitState)),
new TaskContext(workUnitState), countDownLatch, this.taskStateTracker);
```
Ideally, we should create the TaskContext once, and reuse the same
TaskContext.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345721)
Remaining Estimate: 0h
Time Spent: 10m
> Inconsistent TaskContext/TaskState created for TaskIFaceWrapper in
> GobblinMultiTaskAttempt
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-963
> URL: https://issues.apache.org/jira/browse/GOBBLIN-963
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Chen Guo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently in GobblinMultiTaskAttempt, when we call createTaskRunnable, we
> rely on a TaskFactory to create a task and return a wrapper for that task.
> However, when we create the wrapper, we initialized the TaskContext twice.
> # For the task creation
> # For the task wrapper creation
> These two TaskContexts, which generate two copies of TaskState, will cause
> inconsistency in the following operation. The task state update within the
> task won't be reflected in TaskWrapper.
>
> Specifically, this is the buggy line of code
> {code:java}
> return new TaskIFaceWrapper(taskFactoryOpt.get().createTask(new
> TaskContext(workUnitState)),
> new TaskContext(workUnitState), countDownLatch, this.taskStateTracker);
> {code}
> Ideally, we should create the TaskContext once, and reuse the same
> TaskContext.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
