[
https://issues.apache.org/jira/browse/GOBBLIN-963?focusedWorklogId=346139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346139
]
ASF GitHub Bot logged work on GOBBLIN-963:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 17:58
Start Date: 19/Nov/19 17:58
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2818: [GOBBLIN-963]
Remove duplicated copies of TaskContext/TaskState when constructing
TaskIFaceWrapper
URL: https://github.com/apache/incubator-gobblin/pull/2818#discussion_r348078839
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -78,8 +78,7 @@
/**
* Commit {@link GobblinMultiTaskAttempt} immediately after running is
done.
*/
- IMMEDIATE,
- /**
+ IMMEDIATE, /**
Review comment:
Is this intentional? Shouldn't the "/**" start on a new line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 346139)
Time Spent: 0.5h (was: 20m)
> Inconsistent TaskContext/TaskState created for TaskIFaceWrapper in
> GobblinMultiTaskAttempt
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-963
> URL: https://issues.apache.org/jira/browse/GOBBLIN-963
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Chen Guo
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently in GobblinMultiTaskAttempt, when we call createTaskRunnable, we
> rely on a TaskFactory to create a task and return a wrapper for that task.
> However, when we create the wrapper, we initialized the TaskContext twice.
> # For the task creation
> # For the task wrapper creation
> These two TaskContexts, which generate two copies of TaskState, will cause
> inconsistency in the following operation. The task state update within the
> task won't be reflected in TaskWrapper.
>
> Specifically, this is the buggy line of code
> {code:java}
> return new TaskIFaceWrapper(taskFactoryOpt.get().createTask(new
> TaskContext(workUnitState)),
> new TaskContext(workUnitState), countDownLatch, this.taskStateTracker);
> {code}
> Ideally, we should create the TaskContext once, and reuse the same
> TaskContext.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
