[
https://issues.apache.org/jira/browse/GOBBLIN-974?focusedWorklogId=347704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347704
]
ASF GitHub Bot logged work on GOBBLIN-974:
------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 21:22
Start Date: 21/Nov/19 21:22
Worklog Time Spent: 10m
Work Description: jack-moseley commented on pull request #2820:
[GOBBLIN-974] Avoid updating job/flow status if messages arrive out of order
URL: https://github.com/apache/incubator-gobblin/pull/2820#discussion_r349324016
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -146,6 +151,19 @@ static void
addJobStatusToStateStore(org.apache.gobblin.configuration.State jobS
String storeName = jobStatusStoreName(flowGroup, flowName);
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
+ List<org.apache.gobblin.configuration.State> states =
stateStore.getAll(storeName, tableName);
+ if (states.size() > 0) {
+ String previousStatus = states.get(states.size() -
1).getProp(JobStatusRetriever.EVENT_NAME_FIELD);
+ String currentStatus =
jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
Review comment:
It returns null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347704)
Time Spent: 1h (was: 50m)
> Avoid updating job/flow status if messages arrive out of order
> --------------------------------------------------------------
>
> Key: GOBBLIN-974
> URL: https://issues.apache.org/jira/browse/GOBBLIN-974
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
