[
https://issues.apache.org/jira/browse/GOBBLIN-974?focusedWorklogId=347739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347739
]
ASF GitHub Bot logged work on GOBBLIN-974:
------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 22:17
Start Date: 21/Nov/19 22:17
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2820: [GOBBLIN-974]
Avoid updating job/flow status if messages arrive out of order
URL:
https://github.com/apache/incubator-gobblin/pull/2820#issuecomment-556552697
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=h1)
Report
> Merging
[#2820](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/e41fd943f096792598c213ec016f207a9a8f87fc?src=pr&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `92.3%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2820 +/- ##
============================================
- Coverage 45.63% 45.61% -0.02%
- Complexity 8966 8967 +1
============================================
Files 1900 1902 +2
Lines 71222 71272 +50
Branches 7857 7863 +6
============================================
+ Hits 32499 32511 +12
- Misses 35734 35768 +34
- Partials 2989 2993 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==)
| `66.66% <92.3%> (+4.54%)` | `14 <0> (+2)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
|
[...ime/spec\_executorInstance/LocalFsSpecExecutor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19leGVjdXRvckluc3RhbmNlL0xvY2FsRnNTcGVjRXhlY3V0b3IuamF2YQ==)
| `0% <0%> (ø)` | `0% <0%> (?)` | |
|
[...ime/spec\_executorInstance/LocalFsSpecProducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19leGVjdXRvckluc3RhbmNlL0xvY2FsRnNTcGVjUHJvZHVjZXIuamF2YQ==)
| `0% <0%> (ø)` | `0% <0%> (?)` | |
|
[...act/kafka/workunit/packer/KafkaWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FXb3JrVW5pdFBhY2tlci5qYXZh)
| `16.31% <0%> (+0.27%)` | `7% <0%> (+1%)` | :arrow_up: |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
| ... and [2
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=footer).
Last update
[e41fd94...48270eb](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 347739)
Time Spent: 1h 20m (was: 1h 10m)
> Avoid updating job/flow status if messages arrive out of order
> --------------------------------------------------------------
>
> Key: GOBBLIN-974
> URL: https://issues.apache.org/jira/browse/GOBBLIN-974
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
