[
https://issues.apache.org/jira/browse/GOBBLIN-983?focusedWorklogId=349918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349918
]
ASF GitHub Bot logged work on GOBBLIN-983:
------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/19 18:05
Start Date: 26/Nov/19 18:05
Worklog Time Spent: 10m
Work Description: Will-Lo commented on pull request #2829: [GOBBLIN-983]
Use java string library for string format
URL: https://github.com/apache/incubator-gobblin/pull/2829
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-983
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
There is a dependency on javafx. Javafx is usually used for building desktop
applications, so the package is not included on some versions of java that run
on servers, such as the Docker container. Since this is just string formatting
we can replace it with Java's library
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
1 line change
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 349918)
Remaining Estimate: 0h
Time Spent: 10m
> Replace javafx stringformatter with Java's String library
> ---------------------------------------------------------
>
> Key: GOBBLIN-983
> URL: https://issues.apache.org/jira/browse/GOBBLIN-983
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is one instance of `com.sun.javafx.binding.StringFormatter`. Using
> javafx libraries is not available in many versions of java that run on
> server. Since it's only used to format a string, proposal to use Java's
> String library instead
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
