[
https://issues.apache.org/jira/browse/GOBBLIN-983?focusedWorklogId=349955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349955
]
ASF GitHub Bot logged work on GOBBLIN-983:
------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/19 19:12
Start Date: 26/Nov/19 19:12
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2829: [GOBBLIN-983] Use
java string library for string format
URL:
https://github.com/apache/incubator-gobblin/pull/2829#issuecomment-558776546
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=h1)
Report
> Merging
[#2829](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/1da1e4040f95c9acba497ee208bf8c996cc8c9e8?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2829 +/- ##
============================================
- Coverage 45.62% 45.62% -0.01%
Complexity 8971 8971
============================================
Files 1902 1902
Lines 71284 71284
Branches 7862 7862
============================================
- Hits 32523 32522 -1
Misses 35771 35771
- Partials 2990 2991 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ro/JsonElementConversionWithAvroSchemaFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbldpdGhBdnJvU2NoZW1hRmFjdG9yeS5qYXZh)
| `68% <0%> (ø)` | `6 <0> (ø)` | :arrow_down: |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=footer).
Last update
[1da1e40...b99b4a0](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 349955)
Time Spent: 0.5h (was: 20m)
> Replace javafx stringformatter with Java's String library
> ---------------------------------------------------------
>
> Key: GOBBLIN-983
> URL: https://issues.apache.org/jira/browse/GOBBLIN-983
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There is one instance of `com.sun.javafx.binding.StringFormatter`. Using
> javafx libraries is not available in many versions of java that run on
> server. Since it's only used to format a string, proposal to use Java's
> String library instead
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
