ZihanLi58 commented on a change in pull request #2827: [COBBLIN-981]Handle
backward compatibility issue in HiveSource
URL: https://github.com/apache/incubator-gobblin/pull/2827#discussion_r351016158
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/source/HiveSource.java
##########
@@ -276,6 +279,11 @@ protected void
createWorkunitForNonPartitionedTable(HiveDataset hiveDataset, boo
}
}
+ @Deprecated
+ protected HiveWorkUnit workUnitForTable(HiveDataset hiveDataset) throws
IOException {
Review comment:
I did not do this because state is not a public variable. And this change
dose not do this is because some of the downstream user has already change
their code to enable the new API. And I also want to make this backward
compatible with the latest version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
