autumnust commented on a change in pull request #2835: GOBBLIN-989: Track and
report record level SLA in Gobblin Kafka Extra…
URL: https://github.com/apache/incubator-gobblin/pull/2835#discussion_r352880035
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaSource.java
##########
@@ -371,6 +372,10 @@ private void
createEmptyWorkUnitsForSkippedPartitions(Map<String, List<WorkUnit>
if (!topicQualified) {
skipWorkUnit(workUnit);
}
+ //Copy the SLA config from SourceState to WorkUnitState.
+ if (state.contains(KafkaSource.RECORD_LEVEL_SLA_MINUTES_KEY)) {
Review comment:
Can this part of logic being packed into `getWorkUnitForTopicPartition` or
even deeper level? I haven't looked into `getWorkUnitForTopicPartition` but
since it has `state` passed in, I am assuming it creates workunit based on
state already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
