autumnust commented on a change in pull request #2835: GOBBLIN-989: Track and
report record level SLA in Gobblin Kafka Extra…
URL: https://github.com/apache/incubator-gobblin/pull/2835#discussion_r352884229
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/KafkaConsumerRecord.java
##########
@@ -38,4 +38,16 @@
* does not provide size (like Kafka 09 clients)
*/
public long getValueSizeInBytes();
+
+ /**
+ * @return the timestamp of the underlying ConsumerRecord.
+ */
+ public default long getTimestamp() { return 0; }
Review comment:
It might be a little bit `c/c++`-ish but shall we merge these two into a
single method like `getLogAppendTime` and when the version of Kafka doesn't
support LogAppendTime, returning minus value or `0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
