sv2000 commented on a change in pull request #2849: HiveDataNode node addition
to support adl and abfs URI for gobblin-se…
URL: https://github.com/apache/incubator-gobblin/pull/2849#discussion_r356873428
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/datanodes/hive/HiveDataNode.java
##########
@@ -17,30 +17,33 @@
package org.apache.gobblin.service.modules.flowgraph.datanodes.hive;
+
import java.io.IOException;
import java.net.URI;
import com.google.common.base.Preconditions;
import com.typesafe.config.Config;
+import java.util.Arrays;
import joptsimple.internal.Strings;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import org.apache.gobblin.annotation.Alpha;
import org.apache.gobblin.service.modules.flowgraph.FlowGraphConfigurationKeys;
-import org.apache.gobblin.service.modules.flowgraph.datanodes.fs.HdfsDataNode;
+import
org.apache.gobblin.service.modules.flowgraph.datanodes.fs.FileSystemDataNode;
import org.apache.gobblin.util.ConfigUtils;
/**
- * An abstract {@link HiveDataNode} implementation. In addition to the
required properties of a {@link HdfsDataNode}, an {@link HiveDataNode}
+ * An abstract {@link HiveDataNode} implementation. In addition to the
required properties of a {@link FileSystemDataNode}, an {@link HiveDataNode}
* must have a metastore URI specified.
*/
@Alpha
@EqualsAndHashCode (callSuper = true)
-public class HiveDataNode extends HdfsDataNode {
+public class HiveDataNode extends FileSystemDataNode {
public static final String METASTORE_URI_KEY =
FlowGraphConfigurationKeys.DATA_NODE_PREFIX + "hive.metastore.uri";
+ private static final String[] HIVE_SUPPORTED_SCHEME = {"adl", "abfs",
"hdfs"};
Review comment:
Maybe we should drop supported schemes check. There could be other schemes
(e.g. Hive on AWS) which the current list misses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
