sv2000 commented on a change in pull request #2849: HiveDataNode node addition
to support adl and abfs URI for gobblin-se…
URL: https://github.com/apache/incubator-gobblin/pull/2849#discussion_r356886426
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/datanodes/hive/HiveDataNode.java
##########
@@ -82,23 +81,4 @@ public boolean isMetastoreUriValid(URI metastoreUri) {
return true;
}
- /**
- * @param fsUri FileSystem URI
- * @return true if the scheme has a value of {"adl", "abfs", "hdfs"} and
authority is not empty.
- */
-
- @Override
- public boolean isUriValid(URI fsUri) {
- String scheme = fsUri.getScheme();
- //Check that the scheme is "adl"
- if (!Arrays.asList(HIVE_SUPPORTED_SCHEME).contains(scheme)) {
- return false;
- }
- //Ensure that the authority is not empty
- if (com.google.common.base.Strings.isNullOrEmpty(fsUri.getAuthority())) {
Review comment:
Maybe useful to keep the authority check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
