[
https://issues.apache.org/jira/browse/GOBBLIN-1016?focusedWorklogId=371984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371984
]
ASF GitHub Bot logged work on GOBBLIN-1016:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/20 23:22
Start Date: 14/Jan/20 23:22
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2863: GOBBLIN-1016:
Allow Gobblin Application Master to join Helix cluster …
URL:
https://github.com/apache/incubator-gobblin/pull/2863#issuecomment-572836083
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=h1)
Report
> Merging
[#2863](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc)
will **increase** coverage by `0.08%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2863 +/- ##
============================================
+ Coverage 45.72% 45.81% +0.08%
- Complexity 9085 9111 +26
============================================
Files 1913 1917 +4
Lines 72021 72188 +167
Branches 7943 7968 +25
============================================
+ Hits 32929 33070 +141
- Misses 36074 36089 +15
- Partials 3018 3029 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=)
| `54.16% <ø> (ø)` | `19 <0> (ø)` | :arrow_down: |
|
[.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh)
| `63.04% <0%> (-2.13%)` | `4 <0> (ø)` | |
|
[...e/gobblin/yarn/AbstractYarnAppSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vQWJzdHJhY3RZYXJuQXBwU2VjdXJpdHlNYW5hZ2VyLmphdmE=)
| `48.75% <100%> (+2.59%)` | `6 <1> (+3)` | :arrow_up: |
|
[...obblin/yarn/YarnAppSecurityManagerWithKeytabs.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkFwcFNlY3VyaXR5TWFuYWdlcldpdGhLZXl0YWJzLmphdmE=)
| `25.64% <33.33%> (+5.05%)` | `2 <0> (ø)` | :arrow_down: |
|
[...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh)
| `21.39% <90.9%> (+1.44%)` | `8 <0> (+1)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.81% <0%> (ø)` | `27% <0%> (-1%)` | :arrow_down: |
|
[...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==)
| `77.04% <0%> (ø)` | `11% <0%> (?)` | |
| ... and [10
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=footer).
Last update
[4483268...164f80f](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 371984)
Time Spent: 1h 40m (was: 1.5h)
> Allow Gobblin Application Master to join Helix cluster in PARTICIPANT mode
> when Helix cluster is managed
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1016
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1016
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In the managed cluster mode, the Gobblin Yarn Application Master joins Helix
> cluster in the ADMINISTRATOR role. However, Helix does not support messaging
> for instances which are not CONTROLLER or PARTICIPANT. To properly handle
> shutdown and token file update messages, the AppMaster should connect to the
> Helix cluster as a PARTICIPANT, these message types need to be destined to
> PARTICIPANT instead of CONTROLLER as is the case today.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
