sv2000 commented on a change in pull request #2870: [GOBBLIN-1027] add metrics
for users running gaas jobs
URL: https://github.com/apache/incubator-gobblin/pull/2870#discussion_r367228156
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -788,6 +794,33 @@ private ContextAwareCounter
getRunningJobsCounter(DagNode<JobExecutionPlan> dagN
dagNode.getValue().getSpecExecutor().getUri().toString()));
}
+ private List<ContextAwareCounter>
getRunningJobsCounterForUser(DagNode<JobExecutionPlan> dagNode) {
+ Properties props =
dagNode.getValue().getJobSpec().getConfigAsProperties();
Review comment:
I think we should as a rule use typesafe config unless usage of Java
properties is necessary (e.g. for Azkaban AbstractJob or maintaining backwards
compatibility). Typesafe config has many advantages over Properties. In
gobblin-service, we largely use typesafe config. From the point of view of
maintaiining code uniformity, I think usage of config is desirable. We also
have developed a bunch of utility methods around typesafe config in Gobblin
ConfigUtils that has made the usage of typesafe config even more attractive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
