sv2000 commented on a change in pull request #2870: [GOBBLIN-1027] add metrics
for users running gaas jobs
URL: https://github.com/apache/incubator-gobblin/pull/2870#discussion_r367231206
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -796,7 +796,7 @@ private ContextAwareCounter
getRunningJobsCounter(DagNode<JobExecutionPlan> dagN
private List<ContextAwareCounter>
getRunningJobsCounterForUser(DagNode<JobExecutionPlan> dagNode) {
Properties props =
dagNode.getValue().getJobSpec().getConfigAsProperties();
- String proxy = props.getProperty("user.to.proxy");
+ String proxy = props.getProperty(AzkabanProjectConfig.USER_TO_PROXY);
List<ContextAwareCounter> counters = new ArrayList<>();
if (proxy != null) {
Review comment:
Nit: Can this be replaced with if (!Strings.isNullOrEmpty(proxy)) similar to
what you have in line 811?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
