[
https://issues.apache.org/jira/browse/GOBBLIN-1034?focusedWorklogId=378393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378393
]
ASF GitHub Bot logged work on GOBBLIN-1034:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/20 18:33
Start Date: 28/Jan/20 18:33
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2876: GOBBLIN-1034:
Ensure underlying writers are expired from the Partitio…
URL: https://github.com/apache/incubator-gobblin/pull/2876
…nedDataWriter cache to avoid accumulation of writers for long running
Gobblin jobs
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1034
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Currently, the underlying writers are never evicted from the
PartitionedDataWriter cache. For long running Gobblin jobs (e.g. streaming),
this will cause a memory leak particularly if the underlying writers maintain
state.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added unit test.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 378393)
Remaining Estimate: 0h
Time Spent: 10m
> Ensure underlying writers are expired from the PartitionedDataWriter cache to
> avoid accumulation of writers for long running Gobblin jobs
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1034
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1034
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the underlying writers are never evicted from the
> PartitionedDataWriter cache. For long running Gobblin jobs (e.g. streaming),
> this will cause a memory leak particularly if the underlying writers maintain
> state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
