[
https://issues.apache.org/jira/browse/GOBBLIN-1034?focusedWorklogId=379655&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379655
]
ASF GitHub Bot logged work on GOBBLIN-1034:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/20 23:02
Start Date: 30/Jan/20 23:02
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2876: GOBBLIN-1034:
Ensure underlying writers are expired from the Partitio…
URL:
https://github.com/apache/incubator-gobblin/pull/2876#issuecomment-579409509
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=h1)
Report
> Merging
[#2876](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/66e201ceefad1b97fcad83b50f2954e48ef2d0f4?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
> The diff coverage is `88.57%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2876 +/- ##
============================================
- Coverage 45.79% 45.76% -0.03%
- Complexity 9109 9113 +4
============================================
Files 1915 1921 +6
Lines 72293 72378 +85
Branches 7974 7965 -9
============================================
+ Hits 33106 33124 +18
- Misses 36161 36226 +65
- Partials 3026 3028 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...g/apache/gobblin/writer/PartitionedDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9QYXJ0aXRpb25lZERhdGFXcml0ZXIuamF2YQ==)
| `62.63% <88.57%> (+3.73%)` | `33 <5> (+5)` | :arrow_up: |
|
[.../org/apache/gobblin/async/AsyncDataDispatcher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2FzeW5jL0FzeW5jRGF0YURpc3BhdGNoZXIuamF2YQ==)
| `79.66% <0%> (-8.48%)` | `13% <0%> (-1%)` | |
|
[...obblin/service/monitoring/FlowStatusGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9GbG93U3RhdHVzR2VuZXJhdG9yLmphdmE=)
| `69.69% <0%> (-4.5%)` | `11% <0%> (ø)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `76.54% <0%> (-1.04%)` | `13% <0%> (+1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.76% <0%> (-0.46%)` | `27% <0%> (-1%)` | |
|
[...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh)
| `54.71% <0%> (-0.04%)` | `25% <0%> (ø)` | |
|
[...a/org/apache/gobblin/service/FlowStatusClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzQ2xpZW50LmphdmE=)
| `72.34% <0%> (ø)` | `7% <0%> (ø)` | :arrow_down: |
|
[...org/apache/gobblin/service/FlowStatusResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzUmVzb3VyY2UuamF2YQ==)
| `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [11
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2876/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=footer).
Last update
[66e201c...8df158d](https://codecov.io/gh/apache/incubator-gobblin/pull/2876?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379655)
Time Spent: 1h 40m (was: 1.5h)
> Ensure underlying writers are expired from the PartitionedDataWriter cache to
> avoid accumulation of writers for long running Gobblin jobs
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1034
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1034
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, the underlying writers are never evicted from the
> PartitionedDataWriter cache. For long running Gobblin jobs (e.g. streaming),
> this will cause a memory leak particularly if the underlying writers maintain
> state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
