[ https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386122 ]
ASF GitHub Bot logged work on GOBBLIN-1048: ------------------------------------------- Author: ASF GitHub Bot Created on: 12/Feb/20 18:37 Start Date: 12/Feb/20 18:37 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2888: GOBBLIN-1048: Provide an option to pass and set System properties via… URL: https://github.com/apache/incubator-gobblin/pull/2888#discussion_r378437965 ########## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java ########## @@ -150,6 +150,10 @@ public GobblinClusterManager(String clusterName, String applicationId, Config co this.applicationId = applicationId; + //Helix uses System#getProperty() for ZK configuration overrides such as sessionTimeout. The overrides specified Review comment: Since this is useful for any configuration, let's fix the comment which gives me impression that only ZK configuration's overrides are loaded from system configuration. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 386122) Time Spent: 20m (was: 10m) > Provide an option to pass and set System properties via Gobblin Cluster > application config > ------------------------------------------------------------------------------------------ > > Key: GOBBLIN-1048 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1048 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-cluster > Affects Versions: 0.15.0 > Reporter: Sudarshan Vasudevan > Assignee: Hung Tran > Priority: Major > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) > via Java System properties. This task provides an ability to pass system > overrides via Gobblin Cluster application configuration and sets these > overrides in the cluster manager and task runners. -- This message was sent by Atlassian Jira (v8.3.4#803005)