[
https://issues.apache.org/jira/browse/GOBBLIN-1054?focusedWorklogId=388630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388630
]
ASF GitHub Bot logged work on GOBBLIN-1054:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/20 02:08
Start Date: 18/Feb/20 02:08
Worklog Time Spent: 10m
Work Description: KumaravelKandasami commented on pull request #2894:
GOBBLIN-1054: Refactor HiveSource to make partition filter extensible
URL: https://github.com/apache/incubator-gobblin/pull/2894
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-1054) "GOBBLIN-1054:
Refactor HiveSource to make partition filter extensible"
- https://issues.apache.org/jira/browse/GOBBLIN-1054
### Description
- [x] Refactor HiveSource to handle different partition filter.
Currently the default partition filter is the LookbackPartitionFilter, this
change allows dynamic parition filters through runtime configuration. Added
DateRangePartitionFilter along with this PR.
### Tests
- [X] Added following unit tests
LookbackPartitionFilterGeneratorTest.java
DateRangePartitionFilterGeneratorTest.java
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 388630)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor HiveSource to make partition filter extensible
> -------------------------------------------------------
>
> Key: GOBBLIN-1054
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1054
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
