[
https://issues.apache.org/jira/browse/GOBBLIN-1054?focusedWorklogId=392349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392349
]
ASF GitHub Bot logged work on GOBBLIN-1054:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 07:48
Start Date: 25/Feb/20 07:48
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2894: GOBBLIN-1054:
Refactor HiveSource to make partition filter extensible
URL:
https://github.com/apache/incubator-gobblin/pull/2894#issuecomment-587259006
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=h1)
Report
> Merging
[#2894](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/166eb725c01c279068aaefa2c9af93c907bd9eff?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
> The diff coverage is `67.5%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2894 +/- ##
============================================
- Coverage 45.81% 45.77% -0.05%
- Complexity 9148 9160 +12
============================================
Files 1929 1933 +4
Lines 72602 72801 +199
Branches 7993 8026 +33
============================================
+ Hits 33264 33323 +59
- Misses 36303 36415 +112
- Partials 3035 3063 +28
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../management/conversion/hive/source/HiveSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9zb3VyY2UvSGl2ZVNvdXJjZS5qYXZh)
| `66.85% <100%> (+3.26%)` | `24 <0> (ø)` | :arrow_down: |
|
[...hive/filter/DateRangePartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvRGF0ZVJhbmdlUGFydGl0aW9uRmlsdGVyR2VuZXJhdG9yLmphdmE=)
| `50% <50%> (ø)` | `4 <4> (?)` | |
|
[.../hive/filter/LookbackPartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvTG9va2JhY2tQYXJ0aXRpb25GaWx0ZXJHZW5lcmF0b3IuamF2YQ==)
| `78.94% <76.47%> (-21.06%)` | `6 <5> (+3)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `38.26% <0%> (-4.22%)` | `14% <0%> (-1%)` | |
|
[...org/apache/gobblin/runtime/api/FsSpecConsumer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY0NvbnN1bWVyLmphdmE=)
| `60% <0%> (-3.83%)` | `6% <0%> (+1%)` | |
|
[...org/apache/gobblin/runtime/api/FsSpecProducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY1Byb2R1Y2VyLmphdmE=)
| `72.54% <0%> (-3.07%)` | `9% <0%> (+1%)` | |
|
[...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=)
| `30.55% <0%> (-2.78%)` | `2% <0%> (ø)` | |
|
[...he/gobblin/writer/FineGrainedWatermarkTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL0ZpbmVHcmFpbmVkV2F0ZXJtYXJrVHJhY2tlci5qYXZh)
| `82.25% <0%> (-2.42%)` | `28% <0%> (-1%)` | |
|
[...anagement/copy/replication/ConfigBasedDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWREYXRhc2V0LmphdmE=)
| `68.87% <0%> (-1.68%)` | `10% <0%> (ø)` | |
| ... and [23
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2894/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=footer).
Last update
[166eb72...dca6e66](https://codecov.io/gh/apache/incubator-gobblin/pull/2894?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392349)
Time Spent: 1.5h (was: 1h 20m)
> Refactor HiveSource to make partition filter extensible
> -------------------------------------------------------
>
> Key: GOBBLIN-1054
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1054
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
