[
https://issues.apache.org/jira/browse/GOBBLIN-1050?focusedWorklogId=390278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390278
]
ASF GitHub Bot logged work on GOBBLIN-1050:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 21:55
Start Date: 20/Feb/20 21:55
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2890: [GOBBLIN-1050]
Verify requester when updating/deleting FlowConfig
URL:
https://github.com/apache/incubator-gobblin/pull/2890#issuecomment-589346109
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=h1)
Report
> Merging
[#2890](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/6cca9eb55c9b64556d75de999ba762b5c886378b?src=pr&el=desc)
will **increase** coverage by `0.1%`.
> The diff coverage is `7.14%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
+ Coverage 45.7% 45.8% +0.1%
- Complexity 9115 9150 +35
==========================================
Files 1923 1929 +6
Lines 72474 72663 +189
Branches 7974 8001 +27
==========================================
+ Hits 33125 33285 +160
- Misses 36324 36342 +18
- Partials 3025 3036 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==)
| `12.21% <0%> (-1.47%)` | `2 <0> (ø)` | |
|
[.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...rg/apache/gobblin/service/FlowConfigsResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1Jlc291cmNlLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...re/ControllerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0NvbnRyb2xsZXJVc2VyRGVmaW5lZE1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh)
| `39.06% <0%> (-12.5%)` | `4 <0> (ø)` | |
|
[...estli/GobblinServiceFlowConfigResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93Q29uZmlnUmVzb3VyY2VIYW5kbGVyLmphdmE=)
| `44.61% <40%> (-6.16%)` | `11 <0> (ø)` | |
|
[...obblin/service/modules/flowgraph/BaseDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvQmFzZURhdGFOb2RlLmphdmE=)
| `66.66% <0%> (-8.34%)` | `5% <0%> (ø)` | |
|
[...gobblin/service/modules/spec/JobExecutionPlan.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zcGVjL0pvYkV4ZWN1dGlvblBsYW4uamF2YQ==)
| `68.05% <0%> (-7.76%)` | `9% <0%> (ø)` | |
|
[...modules/flowgraph/datanodes/hive/HiveDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2hpdmUvSGl2ZURhdGFOb2RlLmphdmE=)
| `63.15% <0%> (-7.44%)` | `4% <0%> (ø)` | |
| ... and [46
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2890/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=footer).
Last update
[6cca9eb...9f42d46](https://codecov.io/gh/apache/incubator-gobblin/pull/2890?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 390278)
Time Spent: 20m (was: 10m)
> Verify requester when updating/deleting FlowConfig
> --------------------------------------------------
>
> Key: GOBBLIN-1050
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1050
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
